Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-84030881
sorry this was a miscommunication between the three of us
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-84022943
@gyfora, did you really have to push this so eagerly?
1. The behaviour is not documented anywhere
1. Commit b6f183a is just plain useless after the rebase
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83774008
@StephanEwen @uce I definitely agree, thanks for the feedback!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83491306
Just a minor thing: I vote that PR titles should include some text about
what the PR is about, for example like the first commit msg. That way it is
easier to figure out what
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83451729
Change looks good, but can you try and stick with the code style of the
remaining project?
---
If your project is set up for it, you can reply to this email and have
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83197775
Indeed, cool. Good to know
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83196855
Sure, rebasing to master does that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83196555
Thanks @mbalassi! If you merge can you remove the quickfix (2872308)? It
looks like @hsaputra pushed it already
---
If your project is set up for it, you can reply
Github user senorcarbone commented on a diff in the pull request:
https://github.com/apache/flink/pull/501#discussion_r26711053
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupCombineITCase.java
---
@@ -58,7 +58,7 @@
*/
public class GroupC
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/501#issuecomment-83193360
Added a comment to the JIRA issue, but the suggestion make sense,
@senorcarbone. Let me add a bit of doc and merge this.
---
If your project is set up for it, you can re
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/501#discussion_r26704856
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupCombineITCase.java
---
@@ -58,7 +58,7 @@
*/
public class GroupCombi
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/501#discussion_r26704861
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupCombineITCase.java
---
@@ -276,7 +276,7 @@ public void
testPartialReduceWith
GitHub user senorcarbone opened a pull request:
https://github.com/apache/flink/pull/501
Flink 1740
We now use the config parameter for numberofExecutionRetries on the
generated job graph.
Also piggypacked a minor fix for a compilation error that currently occurs
in flink-test
14 matches
Mail list logo
