[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/1560#discussion_r51408033 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java --- @@ -177,21 +177,19 @@

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread tedyu
Github user tedyu closed the pull request at: https://github.com/apache/flink/pull/1560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-02-01 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1560#issuecomment-178029684 Thanks for the pull request. The issue has been identified in the meantime. It is only a testing issue and not a synchronization issue in the RMQSource. --- If your

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-01-29 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/1560#discussion_r51240892 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java --- @@ -177,21 +177,19

[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...

2016-01-28 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/1560 FLINK-3301 Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState This PR changes synchronization on pendingCheckpoints to this (MessageAcknowledgingSourceBase) You can merge