Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-195605736
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-195540338
merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-195034317
are there any objections to merging this? let's get this one in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-193338674
Thanks a lot @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-193337830
looks like something went wrong while rebasing, a commit by aljoscha
suddenly popped up.
but hey, that can be fixed while merging, +1 from me.
---
If you
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-193330011
@StephanEwen , @zentol I just rebased to the latest master.
It passes all tests on my Travis
(https://travis-ci.org/kl0u/flink/builds/114228524).
Please revi
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-187143786
Just rebased. Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185830388
Please Review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185734236
The problem is the CRLF vs LF characters in the committed versions of the
files.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185641724
Changes look good. Do you know what happened to the
ExecutionStateProgressTest diff?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185637076
Please Review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185210139
Hello! I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185271802
Hello!
I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-184259383
Made a few remarks, but didn't find any issue that isn't a minor one. Good
job!
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52912765
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YarnTestBase.java ---
@@ -112,7 +112,7 @@
* lib/ folder of the flink distribution.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52912585
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -75,16 +75,22 @@ public void test
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52912601
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -75,16 +75,22 @@ public void test
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52912014
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1051,7 +1052,8 @@ class JobManager(
}
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52911198
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -225,22 +233,12 @@ public int getNumberOfExecutionRetries() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52911077
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -215,7 +218,12 @@ public void setNumberOfExecutionRetries(int
num
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-184252247
we could probably heavily reduce the diff by providing constructors
with/without the executionconfig argument. (if none is given, we just
instantiate a new one)
---
If
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1583#discussion_r52910257
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -393,7 +393,7 @@ public int run(String[] args) {
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-184236773
Hello! Just rebased to the new master. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-182414285
Please review the new pull request.
This pull request is the first step for the one about FLINK-2523.
Thanks a lot!
---
If your project is set up for it, you
25 matches
Mail list logo
