Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1895
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-215460466
This looks good! ð I just had one inline question where I was hoping
that you already checked it out and can provide some insights.
---
If your project is set up
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r61445422
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -427,18 +434,37 @@ public void open(FileInputSplit
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r61444801
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/BinaryInputFormat.java
---
@@ -284,18 +322,24 @@ public T nextRecord(T record) throws
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-214817636
The problem with this change would be that we do not have yet a way to
deserialize a record, so
when we are trying to advance readRecords in the block, we have a NULL
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-214448465
Hi @aljoscha , thanks a lot for the comments.
I addressed them. Please let me know what do you think.
---
If your project is set up for it, you can reply to this email
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-214358848
I had some inline comments but overall the changes look good!
I think can simplify the `BinaryInputFormat` by getting rid of the
`filePos` and
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60920236
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/CheckpointableInputFormat.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60919358
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/CheckpointableInputFormat.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60916945
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -398,16 +401,20 @@ public FileBaseStatistics
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60915635
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/BinaryInputFormat.java
---
@@ -337,4 +402,18 @@ public int read(byte[] b, int off, int
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60914650
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/BinaryInputFormat.java
---
@@ -40,36 +41,46 @@
import java.util.List;
/**
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1895#discussion_r60913386
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/CheckpointableInputFormat.java
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-214289596
Hi @aljoscha , I integrated your comments.
Let me know what you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-212492749
Thanks for the comments @aljoscha !
I will integrate them and get back to you.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-212473493
Could it happen that an `InputFormat` is opened with some `InputSplit` but
then restored to a position that would lie in another split? Maybe it would
make sense to
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-212468812
I will also squash the commits as soon as I integrate any possible comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-212457887
Could somebody review this?
This is also part of the FLINK-2314 issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1895
FLINK-3717 - Be able to re-start reading from a specific point in a file.
This pull-request addresses issue FLINK-3717 and is the first step to make
File Sources fault-tolerant.
You can merge this
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1895#issuecomment-210450817
This PR addresses FLINK-3717.
Please review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
20 matches
Mail list logo
