Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-152122441
I will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151823317
OK, I can do it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user hczerpak commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151820648
I'm sorry @fhueske but honestly I don't know how to squash the history.
After few tires I've given up yesterday, it didn't happen correctly.
---
If your project is set
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151786552
Thanks for the update.
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151583907
No worries :-)
Thanks for the quick response!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43158439
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/util/SplitStreamType.java
---
@@ -20,10 +20,11 @@
import org.apache.flink.strea
Github user hczerpak commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151583549
Sorry for missclick. Didn't intend to close and reopen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43158080
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
Github user hczerpak closed the pull request at:
https://github.com/apache/flink/pull/1298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
GitHub user hczerpak reopened a pull request:
https://github.com/apache/flink/pull/1298
[FLINK-2559] Fix Javadoc Code Examples
Initially I've made only handful of fixes to javadocs, replacing few @ with
{@literal @}. Running mvn javadoc:javadoc revealed lots of javadoc problems:
Github user hczerpak commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151583330
Sure. I appreciate your comments. It was not always straightforward what to
do with errors. Could you please take a look at my comments above and say what
you think?
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43157767
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43157321
--- Diff:
flink-contrib/flink-tweet-inputformat/src/main/java/org/apache/flink/contrib/tweetinputformat/model/tweet/entities/Entities.java
---
@@ -21,8 +21,
Github user hczerpak commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43156806
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/util/SplitStreamType.java
---
@@ -20,10 +20,11 @@
import org.apache.flink.stre
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1298#issuecomment-151576323
Hi @hczerpak, thanks a lot for the thorough cleaning of the JavaDocs!
I spotted just a few things that should be improved.
The commit history of your PR is also a
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153436
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -219,7 +219,7 @@ void setInDegree(long in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153428
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -206,7 +206,7 @@ void setOutput(Vertex ou
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153270
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -327,7 +327,7 @@ void setInDegree(long inDeg
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43153252
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -314,7 +314,7 @@ public void remove() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43151435
--- Diff:
flink-contrib/flink-tweet-inputformat/src/main/java/org/apache/flink/contrib/tweetinputformat/model/tweet/entities/Entities.java
---
@@ -21,8 +21,8
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1298#discussion_r43151247
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/util/SplitStreamType.java
---
@@ -20,10 +20,11 @@
import org.apache.flink.strea
GitHub user hczerpak opened a pull request:
https://github.com/apache/flink/pull/1298
Flink 2559
Initially I've made only handful of fixes to javadocs, replacing few @ with
{@literal @}. Running mvn javadoc:javadoc revealed lots of javadoc problems:
- broken html tags: `,
23 matches
Mail list logo
