[GitHub] flink pull request: Make streaming iterations more robust

2015-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Make streaming iterations more robust

2015-07-10 Thread gyfora
GitHub user gyfora opened a pull request: https://github.com/apache/flink/pull/900 Make streaming iterations more robust This PR reworks the way iterations are constructed in the streamgraph from the previous eager approach to do it when we actually create the jobgraph.

[GitHub] flink pull request: Make streaming iterations more robust

2015-07-10 Thread senorcarbone
Github user senorcarbone commented on a diff in the pull request: https://github.com/apache/flink/pull/900#discussion_r34352021 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java --- @@

[GitHub] flink pull request: Make streaming iterations more robust

2015-07-10 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/900#issuecomment-120405183 There are quite a few changes in this PR! In general I am very keen to eliminating DataStream mutations and adding that logic into the jobgraph building phase. The

[GitHub] flink pull request: Make streaming iterations more robust

2015-07-10 Thread gyfora
Github user gyfora commented on a diff in the pull request: https://github.com/apache/flink/pull/900#discussion_r34357746 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java --- @@ -201,14

[GitHub] flink pull request: Make streaming iterations more robust

2015-07-10 Thread senorcarbone
Github user senorcarbone commented on a diff in the pull request: https://github.com/apache/flink/pull/900#discussion_r34359293 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/datastream/IterativeDataStream.java --- @@