[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-17 Thread hsaputra
Github user hsaputra closed the pull request at: https://github.com/apache/flink/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-17 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-82605275 This is merged by @StephanEwen with http://git-wip-us.apache.org/repos/asf/flink/commit/72ca014e. Thanks Stephan. --- If your project is set up for it, you can

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-17 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-82530221 I think this should go in. The simple the parameter style the better. And without flags (just with arguments) reads easier, as far as I am concerned. --- If your proj

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-17 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-82475999 Looks like failure nothing to do with the commit. Will merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-79140904 Thanks for the input @fhueske. I am trying to make all the example consistent and removing the parameters seem to be consistent with examples in the command line page.

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78996549 No, you are right. These parameters are not in the documentation, not even in the initial import (June last year). I just got used to them ;-) I still like the exp

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78991357 The issue is that those params are not in command line doc. Or maybe I misread ? Removing unnecessary param will make it easier to read. On Friday, March

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78868258 Its true, the parameters are not necessarily needed, but they don't harm either. In fact, I like it to explicitly specify parameters. I do not see a need to break the API

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-13 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/482#issuecomment-78858625 You can still use the `-a` and `-j` arguments. But its certainly nicer to just specify the name of the jar file and the arguments. +1 to merge. --- If your proj

[GitHub] flink pull request: Remove -j and -a parameters which seemed no lo...

2015-03-12 Thread hsaputra
GitHub user hsaputra opened a pull request: https://github.com/apache/flink/pull/482 Remove -j and -a parameters which seemed no longer valid in the doc example for YARN From: ./bin/flink run -j ./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar \