[GitHub] flink pull request: implement a simple session management

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-114517003 Closing this in favor of the new pull request #858. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: implement a simple session management

Github user mxm closed the pull request at: https://github.com/apache/flink/pull/681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-105982832 Looks very nice now. Few comments: - I suggest to keep the JobID in the JobGraph final and force it to be passed via the constructor. The JobGraphGenerator

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-105983100 After a chat with @mxm , we decided it would be good to merge this sooner and fix point 2 (keeping the actor system alive) in a separate patch. I'll try and address

[GitHub] flink pull request: implement a simple session management

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-104707707 I've updated the pull request. - The `JobID` is now propagated from the `ExecutionEnvironment` to the `JobGraph`. That's why a setter for setting the `JobID` at the

[GitHub] flink pull request: implement a simple session management

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/681#discussion_r30686981 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala --- @@ -609,6 +612,98 @@ WordSpecLike with Matchers with

[GitHub] flink pull request: implement a simple session management

Github user mxm commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-103833918 Thanks for your feedback. You introduce a separate session ID here. Why not use the JobID as the session ID? This is how the logic in the JobManager (that attaches

[GitHub] flink pull request: implement a simple session management

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/681#discussion_r30686986 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala --- @@ -609,6 +612,98 @@ WordSpecLike with Matchers with

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-103073033 You schedule the `removeJob()` call after job is done. Does that mean the job will be removed after that time, even if new activity on that job happens? --- If your

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-103075554 There are quite a few implicit assumptions in this pull request, some of which have quite an impact: - The `Client` is bound to a session now. Should we

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-103072112 You introduce a separate session ID here. Why not use the JobID as the session ID? This is how the logic in the JobManager (that attaches the graphs) currently

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/681#issuecomment-103063104 Weird, this fails with a compilation error: https://travis-ci.org/apache/flink/jobs/62807299 --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/681#discussion_r30510108 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala --- @@ -609,6 +612,98 @@ WordSpecLike with Matchers

[GitHub] flink pull request: implement a simple session management

Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/681#discussion_r30509801 --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/jobmanager/JobManagerITCase.scala --- @@ -609,6 +612,98 @@ WordSpecLike with Matchers

[GitHub] flink pull request: implement a simple session management

GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/681 implement a simple session management This pull request implements a rudimentary session management. Together with the backtracking #640, this will enable users to successively submit jobs to the