Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76199872
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,43 +299,95 @@ public void testIgnoredUnderscoreFiles() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76198999
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/DefaultFilterTest.java
---
@@ -34,14 +34,18 @@
public static Collection
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148927
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148802
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,43 +299,95 @@ public void
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76148725
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/DefaultFilterTest.java
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76056775
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76056623
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,43 +299,95 @@ public void testIgnoredUnderscoreFiles() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r76055091
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/DefaultFilterTest.java
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73213456
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73213488
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -257,41 +257,22 @@ public void testFileInputSplit() {
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73212835
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -995,8 +993,7 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162978
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -257,41 +257,22 @@ public void testFileInputSplit() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162125
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -274,7 +272,7 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162167
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162004
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -274,7 +272,7 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73161791
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -995,8 +993,7 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r68578183
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,41 +297,101 @@ public void
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r67468955
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FilesFilter.java ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r67319452
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FilesFilter.java ---
@@ -0,0 +1,79 @@
+package org.apache.flink.api.common.io;
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r67319428
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FilesFilterTest.java ---
@@ -0,0 +1,33 @@
+package org.apache.flink.api.common.io;
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r67319317
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java ---
@@ -70,7 +70,17 @@
* The fraction that the last split may
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2109
[FLINK-3677] FileInputFormat: Allow to specify include/exclude file name
patterns
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list