[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...

2016-09-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...

2016-09-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2500#discussion_r80238320 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -657,13 +659,17 @@ class CodeGenerator(

[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...

2016-09-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2500#discussion_r80243251 --- Diff: docs/dev/table_api.md --- @@ -2442,6 +3141,18 @@ object TimestampModifier extends ScalarFunction { +### Limitations + +

[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...

2016-09-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2500#discussion_r80237743 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala --- @@ -545,7 +545,9 @@ class CodeGenerator(

[GitHub] flink pull request #2500: [FLINK-4549] [table] Test and document implicitly ...

2016-09-15 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2500 [FLINK-4549] [table] Test and document implicitly supported SQL functions Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consid