Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84276796
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -43,16 +41,18 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288975
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -347,34 +328,17 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84279968
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -189,7 +186,7 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84281147
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84284953
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RichFileInputSplitTest.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288776
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288567
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84285924
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84288480
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84285533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/RichFileInputSplit.java
---
@@ -0,0 +1,153 @@
+/*
+ *
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r84280372
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -199,44 +196,39 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83440189
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
---
@@ -217,13 +217,12 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83432682
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
---
@@ -217,13 +217,12 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83184745
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -60,26 +63,27 @@
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83183505
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -60,26 +63,27 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83017556
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83014810
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83016929
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83005668
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -111,8 +114,8 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83019574
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -295,7 +256,7 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83016682
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83019658
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -107,10 +113,10 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83007178
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83022623
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
---
@@ -257,74 +190,158 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83005541
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -54,8 +55,10 @@
import java.util.List;
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83019134
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -146,102 +152,57 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83004834
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingITCase.java
---
@@ -111,174 +115,191 @@ protected void testProgram()
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83014794
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -578,18 +647,28 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83015686
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -578,18 +647,28 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83006923
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -336,237 +348,294 @@ public int compare(String o1,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83022754
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java
---
@@ -257,74 +190,158 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83020529
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -60,26 +63,27 @@
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r83005706
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
@@ -256,11 +265,11 @@ public int compare(String o1,
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r82871252
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -107,10 +113,10
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r82813612
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -107,10 +113,10 @@
35 matches
Mail list logo
