[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2017-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88332568 --- Diff: pom.xml --- @@ -96,7 +96,7 @@ under the License. 1.7.7 18.0 2.3.7 - 1.7 +

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331708 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -122,11 +122,11 @@ private void runTest(

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331670 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88242077 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-14 Thread melentye
GitHub user melentye opened a pull request: https://github.com/apache/flink/pull/2804 [FLINK-5067] Make Flink compile with 1.8 Java compiler - New type inference rules changed which overloaded methods are picked. - Renamed java.version property in maven to java.minor.version.