[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-27 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98025175 --- Diff: docs/dev/windows.md --- @@ -27,9 +27,13 @@ Windows are at the heart of processing infinite streams. Windows split the strea over which we can a

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98028663 --- Diff: docs/dev/windows.md --- @@ -795,15 +821,17 @@ necessarily the ones that arrive first or last. ## Allowed Lateness -When working

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98026366 --- Diff: docs/dev/windows.md --- @@ -312,9 +328,9 @@ Time intervals can be specified by using one of `Time.milliseconds(x)`, `Time.se they are evaluate

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98026721 --- Diff: docs/dev/windows.md --- @@ -692,30 +708,39 @@ input ## Triggers -A `Trigger` determines when a window (as formed by the `WindowA

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98028299 --- Diff: docs/dev/windows.md --- @@ -692,30 +708,39 @@ input ## Triggers -A `Trigger` determines when a window (as formed by the `WindowA

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98025225 --- Diff: docs/dev/windows.md --- @@ -38,6 +42,17 @@ the rest of the page. [.allowedLateness()] <- optional, else zero .reduce

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98025995 --- Diff: docs/dev/windows.md --- @@ -257,11 +273,11 @@ For example, in China you would have to specify an offset of `Time.hours(-8)`. ### Session Window

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98027639 --- Diff: docs/dev/windows.md --- @@ -692,30 +708,39 @@ input ## Triggers -A `Trigger` determines when a window (as formed by the `WindowA

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98025666 --- Diff: docs/dev/windows.md --- @@ -86,9 +101,10 @@ will be performed by a single task, *i.e.* with parallelism of 1. ## Window Assigners

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-26 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r98028880 --- Diff: docs/dev/windows.md --- @@ -795,15 +821,17 @@ necessarily the ones that arrive first or last. ## Allowed Lateness -When working

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97829270 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97832399 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97823809 --- Diff: docs/dev/windows.md --- @@ -204,72 +221,120 @@ input {% highlight scala %} val input: DataStream[T] = ... -// tumbling event-tim

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97828958 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97827094 --- Diff: docs/dev/windows.md --- @@ -204,72 +221,120 @@ input {% highlight scala %} val input: DataStream[T] = ... -// tumbling event-tim

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97832573 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97828488 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97833002 --- Diff: docs/dev/windows.md --- @@ -758,8 +831,33 @@ input val input: DataStream[T] = ... input -.windowAll() +.keyBy()

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97824676 --- Diff: docs/dev/windows.md --- @@ -23,133 +23,96 @@ specific language governing permissions and limitations under the License. --> -Fli

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97822798 --- Diff: docs/dev/windows.md --- @@ -278,38 +343,39 @@ input {% highlight scala %} val input: DataStream[T] = ... -// tumbling event-time

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97826641 --- Diff: docs/dev/windows.md --- @@ -204,72 +221,120 @@ input {% highlight scala %} val input: DataStream[T] = ... -// tumbling event-tim

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97827894 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97833288 --- Diff: docs/dev/windows.md --- @@ -758,8 +831,33 @@ input val input: DataStream[T] = ... input -.windowAll() +.keyBy()

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97828763 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3191#discussion_r97827610 --- Diff: docs/dev/windows.md --- @@ -622,133 +690,138 @@ input -## Dealing with Late Data +## Triggers -When working with

[GitHub] flink pull request #3191: [FLINK-5529] [FLINK-4752] [docs] Improve / extends...

2017-01-23 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3191 [FLINK-5529] [FLINK-4752] [docs] Improve / extends windowing documentation This PR is for both the issues in the title. It refactors/improves/extends the documentation of the windowing logic in Fli