Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3406
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106648264
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106415566
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106404460
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Li
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106403723
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,153 @@
+/*
+ * L
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395036
--- Diff:
flink-libraries/flink-table/src/main/resources/tableSourceConverter.properties
---
@@ -0,0 +1,19 @@
+#
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Licen
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106394128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licen
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106348421
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,153 @@
+/*
+ * Lice
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106347964
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106348184
--- Diff:
flink-libraries/flink-table/src/main/resources/tableSourceConverter.properties
---
@@ -0,0 +1,19 @@
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106346971
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106349244
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105712740
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,146 @@
+/*
+ * Lice
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105714201
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105704013
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ReadonlyExternalCatalog.scala
---
@@ -0,0 +1,72 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105703538
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/InMemoryExternalCatalog.scala
---
@@ -0,0 +1,155 @@
+/*
+ * Lice
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105703767
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CRUDExternalCatalog.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105384191
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105382341
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licens
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362292
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105316858
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105140265
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105141923
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105138617
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105141214
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105138128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105137565
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105136850
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105124247
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105141370
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105159735
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalCatalogSchemaTest.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105158798
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +64,87 @@ object CommonTestData {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105142163
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,164 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105138498
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogDatabase.scala
---
@@ -0,0 +1,29 @@
+/*
+ * Licen
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105137846
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105138652
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105121440
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105141318
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105179034
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105159600
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/catalog/ExternalCatalogSchemaTest.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Lic
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104401203
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License.
-
+
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104401325
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63 @@
+/*
+ *
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104394065
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104387807
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License.
-
+
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104371759
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License.
-
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104371681
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104371244
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104343965
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104343679
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104340593
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Lic
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104333889
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License.
-
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104188272
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104156636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104176638
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104184922
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104158740
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104160007
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104166130
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104191673
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104178022
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104022427
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License.
-
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104167894
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104159675
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104194149
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104159480
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104167970
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104177526
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licens
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104163154
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104158678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104150546
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104191562
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104185348
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3406
[flink-5568] [Table API & SQL]Introduce interface for catalog, and provide
an in-memory implementation. Integrate external catalog with calcite catalog
This pr aims to introduce interface for cat
77 matches
Mail list logo
