[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3471#discussion_r104613673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala --- @@ -42,6 +41,14 @@ class DataS

[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-06 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3471#discussion_r104606232 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetAggregateRule.scala --- @@ -42,6 +41,14 @@ class Dat

[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-03 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3471 [FLINK-5722] [table] Add dedicated DataSetDistinct operator. A dedicated DISTINCT operator is more efficient because we can use a `ReduceFunction` which (optionally) support hash-based combining. Y