[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-04-05 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-03-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3610#discussion_r108503328 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java --- @@ -80,8 +80,17 @@ public TaskMetricGroup ad

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-03-28 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3610#discussion_r108478998 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java --- @@ -80,8 +80,17 @@ public TaskMetricGro

[GitHub] flink pull request #3610: [FLINK-6183]/[FLINK-6184] Prevent some NPE and unc...

2017-03-24 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3610 [FLINK-6183]/[FLINK-6184] Prevent some NPE and unclosed metric groups This PR fixes 2 issues: 1) It prevents some NPEs in the buffer metrics by instantiating them after the task has been reg