[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-06 Thread shaoxuan-wang
Github user shaoxuan-wang closed the pull request at: https://github.com/apache/flink/pull/3646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r110073336 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -299,27 +299,6 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r110041174 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -299,27 +299,6 @@ class

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109047823 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109047104 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109046506 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109046955 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109039910 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupAggregate.scala --- @@ -0,0 +1,117 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109043405 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala --- @@ -0,0 +1,100 @@ +/*

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109045076 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -123,10 +144,24 @@ class

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109047011 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109042385 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -73,7 +73,7 @@ object

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109034147 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -221,8 +221,8 @@ case class Aggregate(

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109047127 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109046265 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109045587 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109041002 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupAggregate.scala --- @@ -0,0 +1,117 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109046937 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-30 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r109047090 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupAggregationsITCase.scala --- @@ -0,0 +1,304 @@

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-29 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3646 [FLINK-6216] [table] DataStream unbounded groupby aggregate with early firing 1. Implemented an unbounded groupby aggregate with early firing (period is 1, emit per every record) 2.