[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3683 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110110002 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala --- @@ -350,23 +350,18 @@ class

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110108276 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala --- @@ -350,23 +350,18 @@ class

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110107855 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -39,10 +39,53 @@

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110106044 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -39,10 +39,53 @@

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110103104 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -595,6 +595,35 @@ public boolean containsKey(String key){

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110102530 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java --- @@ -39,10 +39,53 @@

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110104138 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java --- @@ -595,6 +595,35 @@ public boolean containsKey(String key){

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3683#discussion_r110102292 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/LocalFlinkMiniCluster.scala --- @@ -350,23 +350,18 @@ class

[GitHub] flink pull request #3683: [FLINK-6270] Port several network config parameter...

2017-04-06 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3683 [FLINK-6270] Port several network config parameters to ConfigOption This ports some memory and network buffers related config options to new `ConfigOption` instances. These include: *