Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4078
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126870195
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -110,6 +110,11 @@ under the License.
compile
+
+
Github user haohui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126870280
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -2008,6 +2008,33 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126747879
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/DateFormatCallGen.scala
---
@@ -0,0 +1,44 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126750513
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala
---
@@ -374,6 +375,7 @@ class BasicOperatorTable
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126747178
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -2008,6 +2008,33 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126748981
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DateTimeSqlFunction.scala
---
@@ -0,0 +1,34 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126746604
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -2008,6 +2008,33 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126746348
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -110,6 +110,11 @@ under the License.
compile
+
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126747228
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/BuiltInMethods.scala
---
@@ -89,5 +89,4 @@ object BuiltInMethods
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r126746651
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -2008,6 +2008,33 @@ class CodeGenerator(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r123717228
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/DateTimeFunctionTest.scala
---
@@ -0,0 +1,49 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r123718414
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala
---
@@ -375,3 +377,13 @@ case class TemporalOverlaps(
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r123718210
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/DateTimeFunctions.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r123718165
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/DateTimeFunctions.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r123718616
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DateTimeSqlFunction.scala
---
@@ -0,0 +1,34 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r122254102
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/DateTimeFunctionTest.scala
---
@@ -0,0 +1,49 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r122240819
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/DateTimeFunctions.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r122255933
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -110,6 +110,12 @@ under the License.
compile
+
+
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4078#discussion_r122255414
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/DateTimeFunctions.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/4078
[FLINK-6693] [table] Support DATE_FORMAT function in the Table / SQL API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink
21 matches
Mail list logo