[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-07-13 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/4112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-07-10 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r126464199 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java --- @@ -61,7 +60,9 @@ public NettyBufferPool(int

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-07-10 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r126451783 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyBufferPool.java --- @@ -61,7 +60,9 @@ public NettyBufferPool(int

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r121495764 --- Diff: tools/maven/suppressions-runtime.xml --- @@ -0,0 +1,29 @@ + + + +http://www.puppycrawl.com/dtds/suppressions_1_1.dtd;> + +

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r121480837 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringValueUtils.java --- @@ -114,15 +114,17 @@ public boolean next(StringValue target) {

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r121480878 --- Diff: tools/maven/suppressions-runtime.xml --- @@ -0,0 +1,29 @@ + + + +http://www.puppycrawl.com/dtds/suppressions_1_1.dtd;> + +

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r121463726 --- Diff: tools/maven/suppressions-runtime.xml --- @@ -0,0 +1,29 @@ + + + +http://www.puppycrawl.com/dtds/suppressions_1_1.dtd;> +

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4112#discussion_r121465225 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringValueUtils.java --- @@ -114,15 +114,17 @@ public boolean next(StringValue target) {

[GitHub] flink pull request #4112: [FLINK-6901] Flip checkstyle configuration files

2017-06-12 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4112 [FLINK-6901] Flip checkstyle configuration files This PR makes the `strict-checkstyle.xml` the default checkstyle configuration. As a first step i made `flink-streaming-scala` checkstyle