[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-07-04 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125445183 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@ -117,12 +11

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-07-04 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125445109 --- Diff: docs/dev/connectors/kinesis.md --- @@ -72,12 +72,80 @@ Before consuming data from Kinesis streams, make sure that all streams are creat

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-07-04 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125445000 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@ -117,12 +11

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-07-04 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125445059 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@ -117,12 +11

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-30 Thread mpouttuclarke
Github user mpouttuclarke commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125076287 --- Diff: docs/dev/connectors/kinesis.md --- @@ -72,12 +72,80 @@ Before consuming data from Kinesis streams, make sure that all streams are creat

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-30 Thread mpouttuclarke
Github user mpouttuclarke commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125074194 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -171

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-30 Thread mpouttuclarke
Github user mpouttuclarke commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r125073534 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -171

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r124967289 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -171,7 +1

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4228#discussion_r124967667 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -171,7 +1

[GitHub] flink pull request #4228: Flink-7035 Automatically identify AWS Region, simp...

2017-06-29 Thread mpouttuclarke
GitHub user mpouttuclarke opened a pull request: https://github.com/apache/flink/pull/4228 Flink-7035 Automatically identify AWS Region, simplified constructors, added test properties support You can merge this pull request into a Git repository by running: $ git pull https:/