[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134692032 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -348,7 +353,18 @@ private void upd

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134692117 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -348,7 +353,18 @@ private void upd

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134687041 --- Diff: docs/dev/libs/cep.md --- @@ -1279,63 +1279,75 @@ and `flatSelect` API calls allow a timeout handler to be specified. This timeout partial event

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134689181 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -84,37 +79,54 @@ class PatternStream[T](jPatter

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132443663 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -82,36 +78,54 @@ class PatternStream[T](jPat

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132446724 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java --- @@ -163,14 +251,34 @@ null,

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132445880 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java --- @@ -107,13 +113,54 @@ * function. *

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132446221 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java --- @@ -213,14 +321,97 @@ * @return {@link DataStream} w

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132446175 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java --- @@ -213,14 +321,97 @@ * @return {@link DataStream} w

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-10 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132445956 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStream.java --- @@ -125,25 +172,66 @@ * partial pattern sequence the

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-07-13 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/4320 [FLINK-6244] Emit timeouted Patterns as Side Output Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your