[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-10 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132490977 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java --- @@ -149,6 +149,13 @@ .defaultValue(50)

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132427008 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java --- @@ -149,6 +149,13 @@ .defaultValue(50)

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132155748 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java --- @@ -101,127 +98,112 @@ public void update() {

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132143993 --- Diff: docs/setup/config.md --- @@ -389,6 +389,10 @@ These parameters allow for advanced tuning. The default values are sufficient wh -

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132142466 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerGateway.java --- @@ -63,4 +70,103 @@ * @return Future

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132142562 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java --- @@ -247,6 +262,8 @@ public static Path

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132142385 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java --- @@ -101,127 +98,112 @@ public void

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132141995 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java --- @@ -101,127 +98,112 @@ public void

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132141830 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebMonitorOptions.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132141613 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebMonitorOptions.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-09 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r132141346 --- Diff: docs/setup/config.md --- @@ -389,6 +389,10 @@ These parameters allow for advanced tuning. The default values are sufficient wh -

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131676491 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java --- @@ -101,127 +98,112 @@ public void update() {

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131680908 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java --- @@ -247,6 +262,8 @@ public static Path

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131683814 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebMonitorOptions.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131671522 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebMonitorOptions.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131675749 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java --- @@ -101,127 +98,112 @@ public void update() {

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131680691 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerGateway.java --- @@ -63,4 +70,103 @@ * @return Future containing

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131671417 --- Diff: docs/setup/config.md --- @@ -389,6 +389,10 @@ These parameters allow for advanced tuning. The default values are sufficient wh -

[GitHub] flink pull request #4492: [FLINK-7381] [web] Decouple WebRuntimeMonitor from...

2017-08-07 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4492 [FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorGateway ## What is the purpose of the change This PR decouples the `WebRuntimeMonitor` from the `ActorGateway` by introducing