Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152813899
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152813796
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152813679
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152813605
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152342531
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -108,11 +108,7 @@ int
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r152342364
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousBufferFileWriter.java
---
@@ -31,9 +31,26 @@ protected
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148534322
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148531290
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousBufferFileWriter.java
---
@@ -31,9 +31,26 @@ protected
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148531416
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -108,11 +108,7 @@ int
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148537550
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -231,31 +255,48 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148532775
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148533217
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4581#discussion_r148532507
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -192,21 +198,39 @@ public void
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4581
[FLINK-7499][io] also let AsynchronousBufferFileWriter#writeBlock() recycle
the buffer in case of failures
## What is the purpose of the change
`SpillableSubpartitionView#releaseMemory()`
14 matches
Mail list logo