[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2018-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4581 ---

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152944166 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152918323 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152918616 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152850290 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152849820 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152849113 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152847273 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152845922 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java --- @@ -145,6 +165,45 @@ protected void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152842686 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java --- @@ -95,20 +95,23 @@ public boolean

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152841030 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java --- @@ -267,28 +268,29 @@ public ResultPartitionType

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152829734 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -320,4 +559,40 @@ void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152822778 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java --- @@ -95,20 +95,23 @@ public boolean

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152826013 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java --- @@ -145,6 +165,45 @@ protected void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152826521 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152825430 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java --- @@ -267,28 +268,29 @@ public

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152827018 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152826839 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] fix double buffer release in Spil...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152837725 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -300,6 +315,230 @@ public void