[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140032946 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java --- @@ -675,6 +679,42 @@ private Lau

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140034034 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java --- @@ -675,6 +679,42 @@ private Lau

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140051191 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosFlinkResourceManager.java --- @@ -663,6 +666,7 @@ private void t

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140021958 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -366,6 +425,34 @@ public Strin

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140022455 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java --- @@ -155,7 +155,7 @@ public int getPort

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-09-20 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140038861 --- Diff: docs/ops/deployment/mesos.md --- @@ -226,6 +226,10 @@ When running Flink with Marathon, the whole Flink cluster including the job mana Take

[GitHub] flink pull request #4628: [FLINK-7486]:[flink-mesos]:Support for adding uniq...

2017-08-30 Thread bbayani
GitHub user bbayani opened a pull request: https://github.com/apache/flink/pull/4628 [FLINK-7486]:[flink-mesos]:Support for adding unique attribute / grou… …p_by attribute constraints JIRA issue: FLINK-7486 ## What is the purpose of the change - To be able to add