Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4710
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r141130569
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/TableSourceTest.scala
---
@@ -121,19 +161,81 @@ class TableSour
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r141124496
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/PushProjectIntoTableSourceScanRule.scala
---
@@ -33,6 +32,9 @
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140778116
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/definedTimeAttributes.scala
---
@@ -30,10 +30,16 @@ package org.apache.f
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140774888
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -255,11 +255,30 @@ abstract class CodeGenerat
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140777209
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala
---
@@ -53,18 +53,11 @@ object StreamTa
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140778244
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/definedTimeAttributes.scala
---
@@ -30,10 +30,16 @@ package org.apache.f
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140782081
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/TableSourceTest.scala
---
@@ -121,19 +161,81 @@ class TableSour
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140771682
--- Diff: docs/dev/table/streaming.md ---
@@ -336,27 +336,24 @@ val windowedTable = tEnv
### Event time
-Event time allows a table progra
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140775690
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalTableSourceScan.scala
---
@@ -47,34 +46,18 @@ cla
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140778313
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/definedTimeAttributes.scala
---
@@ -30,10 +30,16 @@ package org.apache.f
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140774786
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -255,11 +255,30 @@ abstract class CodeGenerat
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/4710#discussion_r140776048
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/logical/PushProjectIntoTableSourceScanRule.scala
---
@@ -33,6 +32,9 @
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4710
[FLINK-7446] [table] Change DefinedRowtimeAttribute to work on existing
field.
## What is the purpose of the change
Changes the contract of the `DefinedRowtimeAttribute` interface. The
row
14 matches
Mail list logo
