[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4722 ---

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141390556 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java --- @@ -190,6 +193,39 @@ protected

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141390478 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java --- @@ -190,6 +193,39 @@ protected

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141272559 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java --- @@ -37,6 +39,12 @@ void setCurrentKey(K newKey);

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-27 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141258536 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1946,4

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141136758 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -1946,4

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-26 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141083304 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -252,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-26 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141090682 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -252,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-26 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141100065 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java --- @@ -287,6 +289,14 @@ public S get(K key, N

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-26 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r141034332 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java --- @@ -442,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r140908693 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -252,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r140907699 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -252,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-25 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r140907101 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -252,6

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4722#discussion_r140821446 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java --- @@ -287,6 +289,14 @@ public S get(K key, N

[GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...

2017-09-25 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4722 [FLINK-7683] Iterate over keys in KeyedStateBackend ## What is the purpose of the change This is required to make possible preserving backward compatibility while changing state