Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4896
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160172988
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/StreamingProgramTestBase.java
---
@@ -66,47 +47,34 @@
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160171312
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160171032
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -18,8 +18,8 @@
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160170300
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
---
@@ -55,6 +55,7
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160165030
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -215,
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160158137
--- Diff:
flink-examples/flink-examples-streaming/src/test/scala/org/apache/flink/streaming/scala/examples/StreamingExamplesITCase.scala
---
@@ -23,8 +
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160157769
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r160156245
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158265225
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package org.apach
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158264752
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/StreamingProgramTestBase.java
---
@@ -66,47 +47,34 @@ protected
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158261437
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -18,8 +18,8 @@
package o
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158260663
--- Diff:
flink-examples/flink-examples-streaming/src/test/scala/org/apache/flink/streaming/scala/examples/StreamingExamplesITCase.scala
---
@@ -23,8 +23,7 @@ i
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259995
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
---
@@ -55,6 +55,7 @@ publi
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158259149
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -215,23 +211,1
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158257284
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package org.apach
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4896#discussion_r158254745
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBase.java
---
@@ -19,81 +19,61 @@
package org.apach
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4896
[FLINK-7909] Unify Flink test bases
## What is the purpose of the change
Introduce a MiniClusterResource which is used by the AbstractTestBase to
start
and shut down a FlinkMiniClu
18 matches
Mail list logo
