Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5088
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r156880342
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/AllocatedSlot.java
---
@@ -144,6 +144,78 @@ public TaskManagerGateway getTaskMa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r156880286
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slo
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r156880229
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r156879027
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java
---
@@ -31,7 +30,7 @@
import static org.mockito.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155296898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/AllocatedSlot.java
---
@@ -144,6 +144,78 @@ public TaskManagerGateway getTaskManagerGate
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155279729
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPool.java ---
@@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155276432
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Sof
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5088#discussion_r155258087
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotsTestImplContext.java
---
@@ -31,7 +30,7 @@
import static org.mockito.Mockito.m
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5088
[FLINK-8087] Decouple Slot from AllocatedSlot
## What is the purpose of the change
This commit introduces the SlotContext which is an abstraction for the
SimpleSlot
to obtain the r
10 matches
Mail list logo