[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-28 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5092 [FLINK-4812][metrics] Expose currentLowWatermark for all operators ## What is the purpose of the change This PR makes all operators expose the current low watermark through the metric system

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153736758 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/metrics/StreamOperatorWatermarkMetricsTest.java --- @@ -0,0 +1,96 @@ +/

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153737987 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorTest.java --- @@ -224,6 +226,39 @@ public voi

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153737439 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/metrics/WatermarkGauge.java --- @@ -0,0 +1,38 @@ +/* + * Licensed t

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153734546 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java --- @@ -313,6 +325,7 @@ protected void proc

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153739683 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorTest.java --- @@ -224,6 +226,39 @@ public voi

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153736792 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/metrics/StreamOperatorWatermarkMetricsTest.java --- @@ -0,0 +1,96 @@ +/

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153748916 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java --- @@ -313,6 +325,7 @@ protected void proces

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153750429 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/metrics/WatermarkGauge.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-11-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5092#discussion_r153760748 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java --- @@ -313,6 +325,7 @@ protected void proc

[GitHub] flink pull request #5092: [FLINK-4812][metrics] Expose currentLowWatermark f...

2017-12-04 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/5092 ---