GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/5115
[FLINK-7692] [metrics] Support user-defined variables in Metrics
## What is the purpose of the change
This pull request makes user can create his own `MetricGroup` with
user-defined vari
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154646500
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(S
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154655734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154665095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(S
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154667460
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154672680
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154904663
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(S
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154906274
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154907808
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154913437
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154924645
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,134 @@ public void sameGroupOnNameCol
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154936137
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGro
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154946902
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -416,10 +441,14 @@ public MetricGroup addGroup(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154947643
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -409,6 +404,22 @@ public MetricGroup addGroup(S
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154965270
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -441,14 +441,14 @@ private MetricGroup addGroup
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r154968275
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -441,14 +441,14 @@ private MetricGroup addG
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r155178904
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,138 @@ public void sameGroupOnNameCollisi
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r155183669
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,138 @@ public void sameGroupOnNameCol
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5115#discussion_r155185291
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/MetricGroupTest.java
---
@@ -78,6 +81,138 @@ public void sameGroupOnNameCollisi
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5115
---
20 matches
Mail list logo
