[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5132 ---

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159926701 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -492,11 +509,16 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159887168 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159878618 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/StreamTableEnvironmentValidationTest.scala --- @@ -138,4 +145,25 @@

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159885776 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159876208 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -446,52 +443,60 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159889511 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -450,37 +450,54 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159878296 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -532,35 +527,27 @@ class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159880719 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -492,11 +509,16 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159877092 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -855,42 +852,26 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159871785 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159853373 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159850168 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159844472 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -768,6 +768,39 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-05 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159841031 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -464,23 +470,29 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159761372 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159771384 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -885,8 +935,23 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159779243 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159766790 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159767413 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159766942 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159777530 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159776065 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -464,23 +470,29 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159758396 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -768,6 +768,39 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159779000 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159764095 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159779026 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala --- @@ -18,231 +18,574 @@ package

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159776487 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -464,23 +470,29 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159770375 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -791,92 +824,109 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159757312 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -768,6 +768,39 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159779494 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/StreamTableEnvironmentValidationTest.scala --- @@ -30,77 +30,88 @@

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2018-01-04 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5132#discussion_r159772482 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala --- @@ -414,11 +414,14 @@ abstract class

[GitHub] flink pull request #5132: [FLINK-8203] [FLINK-7681] [table] Make schema defi...

2017-12-07 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/5132 [FLINK-8203] [FLINK-7681] [table] Make schema definition of DataStream/DataSet to Table conversion more flexible ## What is the purpose of the change This PR makes the schema definition