[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5203 ---

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-24 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158598552 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -481,4 +484,84 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-24 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158598528 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala --- @@ -541,6 +541,48 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-24 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158598561 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala --- @@ -352,4 +354,64 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-24 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158598514 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/CalcITCase.scala --- @@ -352,6 +353,72 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158582395 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -481,4 +484,48 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158582801 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala --- @@ -352,4 +354,38 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158582778 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -481,4 +484,48 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158582780 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala --- @@ -352,4 +354,38 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-23 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5203#discussion_r158582750 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -481,4 +484,48 @@ class

[GitHub] flink pull request #5203: [FLINK-8301] Support Unicode in codegen for SQL &&...

2017-12-21 Thread Xpray
GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/5203 [FLINK-8301] Support Unicode in codegen for SQL && TableAPI ## What is the purpose of the change *support unicode literal in sql and handles code generation correctly