[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2018-01-17 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5205#discussion_r162199532 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -186,7 +186,7 @@ private static long byteArrayToLong(byte[] ba, int

[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2018-01-05 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5205#discussion_r159904126 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -742,7

[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2018-01-05 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5205#discussion_r159899525 --- Diff: flink-core/src/main/java/org/apache/flink/util/AbstractID.java --- @@ -186,7 +186,7 @@ private static long byteArrayToLong(byte[] ba, int

[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2018-01-02 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5205#discussion_r159222950 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/TaskCancelThread.java --- @@ -49,7 +49,7 @@ public

[GitHub] flink pull request #5205: [FLINK-8037] Fix integer multiplication or shift i...

2017-12-22 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5205 [FLINK-8037] Fix integer multiplication or shift implicitly cast to long ## What is the purpose of the change Fixes potential overflow flagged by the IntelliJ inspection "Integer