Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5225
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160995333
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId() {
}
@Overri
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160994352
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160985701
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exc
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160985377
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160978701
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160976939
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160975126
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/DefaultCLITest.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160972443
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Ex
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160970724
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId() {
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160970851
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Ex
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160970084
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId() {
}
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160110442
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/FlinkYarnSessionCliTest.java ---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Found
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160108309
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Found
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159885568
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Sof
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706464
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/DefaultCLITest.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Found
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159703483
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706927
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache S
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707553
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyCustomCommandLine.java
---
@@ -62,12 +63,21 @@ public void addGeneralOptions(Options
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707313
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache S
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159702950
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159656514
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -59,31 +60,49 @@
void addGeneralOptions(Options baseOpti
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159698245
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId() {
}
@Overri
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159698673
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java ---
@@ -56,43 +51,30 @@ public String getId() {
return "fl
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159702188
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception {
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5225
[FLINK-8339] [flip6] Let CustomCommandLine return ClusterDescriptor
## What is the purpose of the change
Instead of directly retrieving or deploying a Flink cluster, the
CustomComma
26 matches
Mail list logo