Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5504
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168749048
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -226,71 +235,72 @@ public int getNumberReporters(
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168737362
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -226,71 +235,72 @@ public int getNumberReporters() {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168735497
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -226,71 +235,72 @@ public int getNumberReporters(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168735349
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -77,19 +85,20 @@
private ViewUpdate
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168728354
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -77,19 +85,20 @@
private ViewUpdater view
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5504#discussion_r168728890
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
---
@@ -226,71 +235,72 @@ public int getNumberReporters() {
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5504
[FLINK-8670] Make MetricRegistryImpl#shutdown non blocking
## What is the purpose of the change
This commit makes the MetricRegistryImpl#shutdown method non blocking.
Instead
of wa
