Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5802#discussion_r179453256
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
@@ -309,8 +309,6 @@ public void testBroadcastEv
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5802#discussion_r179451610
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
---
@@ -164,7 +164,7 @@ public BufferConsumer broadcast
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5802#discussion_r178707684
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
@@ -309,8 +309,6 @@ public void testBroa
GitHub user trionesadam opened a pull request:
https://github.com/apache/flink/pull/5802
[FLINK-9087] [runtime] close the BufferConsumer in RecordWriter.broadâ¦
## What is the purpose of the change
BufferConsumer is Closeable, we'd better close it at last,
#