[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-17 Thread snuyanzin
GitHub user snuyanzin reopened a pull request: https://github.com/apache/flink/pull/5961 [FLINK-8255][DataSet API, DataStream API] key expressions on named row types do not work *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-17 Thread snuyanzin
Github user snuyanzin closed the pull request at: https://github.com/apache/flink/pull/5961 ---

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5961#discussion_r186528901 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/typeutils/FieldAccessorTest.java --- @@ -368,4 +369,23 @@ public void

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5961#discussion_r186484649 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/MaxByOperatorTest.java --- @@ -230,4 +235,43 @@ public String toString() {

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5961#discussion_r186477977 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java --- @@ -41,7 +41,7 @@ * is regarded in the reduce

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5961#discussion_r186527205 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java --- @@ -157,15 +156,15 @@ public T set(T record,

[GitHub] flink pull request #5961: [FLINK-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5961#discussion_r186527277 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java --- @@ -197,7 +196,7 @@ public T set(T record, F

[GitHub] flink pull request #5961: [Flink-8255][DataSet API, DataStream API] key expr...

2018-05-07 Thread snuyanzin
GitHub user snuyanzin opened a pull request: https://github.com/apache/flink/pull/5961 [Flink-8255][DataSet API, DataStream API] key expressions on named row types do not work *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve