GitHub user snuyanzin reopened a pull request:
https://github.com/apache/flink/pull/5961
[FLINK-8255][DataSet API, DataStream API] key expressions on named row
types do not work
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve
Github user snuyanzin closed the pull request at:
https://github.com/apache/flink/pull/5961
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186528901
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/typeutils/FieldAccessorTest.java
---
@@ -368,4 +369,23 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186484649
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/operator/MaxByOperatorTest.java
---
@@ -230,4 +235,43 @@ public String toString() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186477977
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java
---
@@ -41,7 +41,7 @@
* is regarded in the reduce
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186527205
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -157,15 +156,15 @@ public T set(T record,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5961#discussion_r186527277
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
---
@@ -197,7 +196,7 @@ public T set(T record, F
GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/5961
[Flink-8255][DataSet API, DataStream API] key expressions on named row
types do not work
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve