[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188604472 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AllowNonRestoredStateQueryParameter.java --- @@ -42,4 +42,10 @@ public

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188603310 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188603356 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188604063 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188603266 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188603410 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188604321 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188604517 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/EntryClassQueryParameter.java --- @@ -28,4 +28,10 @@ public En

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-16 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r188603431 --- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java --- @@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable String s

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187945098 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/AccumulatorsIncludeSerializedValueQueryParameter.java --- @@ -38,4 +38,10 @

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187944667 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/SavepointPathQueryParameter.java --- @@ -28,4 +28,9 @@ pu

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187944451 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerIdPathParameter.java --- @@ -41,4 +41,9 @@ protected

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187941477 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ProgramArgsQueryParameter.java --- @@ -30,4 +30,8 @@ public Progr

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187940843 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsAggregationParameter.java --- @@ -46,6 +46,13 @@ public

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187939891 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java --- @@ -44,4 +44,9 @@ protected String conve

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187938928 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/TerminationModeQueryParameter.java --- @@ -41,6 +41,11 @@ public String con

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187938285 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsAggregationParameter.java --- @@ -46,6 +46,13 @@ public

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-14 Thread andrew-half
Github user andrew-half commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187938237 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/MessageParametersTest.java --- @@ -109,8 +114,13 @@ public JobID convertStr

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187459062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/AccumulatorsIncludeSerializedValueQueryParameter.java --- @@ -38,4 +38,10 @@

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187460147 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java --- @@ -44,4 +44,9 @@ protected String convert

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187458764 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/SavepointPathQueryParameter.java --- @@ -28,4 +28,9 @@ publ

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187378661 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ProgramArgsQueryParameter.java --- @@ -30,4 +30,8 @@ public ProgramArg

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187377384 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/MessageParametersTest.java --- @@ -109,8 +114,13 @@ public JobID convertStringTo

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187378407 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java --- @@ -44,4 +44,9 @@ protected String convertToS

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187382132 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerIdPathParameter.java --- @@ -41,4 +41,9 @@ protected Reso

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187381371 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsAggregationParameter.java --- @@ -46,6 +46,13 @@ public Strin

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187378111 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsAggregationParameter.java --- @@ -46,6 +46,13 @@ public Strin

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5985#discussion_r187378292 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/TerminationModeQueryParameter.java --- @@ -41,6 +41,11 @@ public String convertV

[GitHub] flink pull request #5985: [FLINK-8135][docs] Add description to MessageParam...

2018-05-10 Thread andrew-half
GitHub user andrew-half opened a pull request: https://github.com/apache/flink/pull/5985 [FLINK-8135][docs] Add description to MessageParameter ## This pull request adds methods for auto-documenting REST API. Introduced getDescription() method will generate path and query pa