[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6067 ---

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190611660 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java --- @@ -1483,6 +1485,216 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190611581 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java --- @@ -1139,6 +1147,61 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190611399 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java --- @@ -1483,6 +1485,216 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190603900 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -732,19 +744,10 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190603365 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java --- @@ -1483,6 +1485,216 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190603934 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190583266 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190557380 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -732,19 +744,10 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190602158 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java --- @@ -1483,6 +1485,216 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6067#discussion_r190602807 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java --- @@ -1139,6 +1147,61 @@ public void

[GitHub] flink pull request #6067: [FLINK-9427] Fix registration and request slot rac...

2018-05-24 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/6067 [FLINK-9427] Fix registration and request slot race condition in TaskExecutor ## What is the purpose of the change This commit fixes a race condition between the TaskExecutor and the