[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192736809 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192736907 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192736862 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192732891 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192733056 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192733087 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -406,6 +407,43 @@ public void onError(Throwable error) {

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192728317 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -356,7 +363,8 @@ public void onContainersAllocated(List

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-06-04 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r192723013 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -356,7 +363,8 @@ public void onContainersAllocated(List

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191166133 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -212,13 +214,12 @@ private void

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191165600 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -510,4 +509,39 @@ private int generatePriority(ResourceProfile

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191165652 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -510,4 +509,39 @@ private int generatePriority(ResourceProfile

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191162993 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -212,13 +214,12 @@ private void

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191162395 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -510,4 +509,39 @@ private int generatePriority(ResourceProfile

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread sihuazhou
Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/6087#discussion_r191162507 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -510,4 +509,39 @@ private int generatePriority(ResourceProfile

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

2018-05-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/6087 [FLINK-9410] [yarn] Replace NMClient with NMClientAsync in YarnResour… …ceManager *Thank you very much for contributing to Apache Flink - we are happy that you want to help