[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204298813 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java --- @@ -189,23 +192,34 @@ public TransportType

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204300332 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java --- @@ -52,6 +56,9 @@ private Bootstrap

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204329262 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java --- @@ -249,14 +357,73 @@ public static SSLContext

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204326191 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java --- @@ -163,80 +163,188 @@ public static void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204330930 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java --- @@ -65,6 +68,60 @@ public void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204336114 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java --- @@ -163,80 +163,188 @@ public static void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204328596 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java --- @@ -163,80 +163,188 @@ public static void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204301373 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java --- @@ -52,6 +56,9 @@ private Bootstrap

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204325132 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java --- @@ -61,6 +63,9 @@ private

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204328091 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java --- @@ -163,80 +163,188 @@ public static void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204324645 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java --- @@ -175,7 +183,6 @@ ChannelFuture connect(final

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204329756 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java --- @@ -65,6 +68,60 @@ public void

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203658272 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java --- @@ -61,6 +62,7 @@ private ChannelFuture

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203657904 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyClient.java --- @@ -52,6 +55,7 @@ private Bootstrap

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203652882 --- Diff: docs/ops/security-ssl.md --- @@ -33,6 +33,9 @@ SSL can be enabled for all network communication between Flink components. SSL k *

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203652194 --- Diff: docs/ops/security-ssl.md --- @@ -33,6 +33,9 @@ SSL can be enabled for all network communication between Flink components. SSL k *

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203617345 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203437995 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203405530 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203326103 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-17 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/6355 [FLINK-9878][network][ssl] add more low-level ssl options ## What is the purpose of the change This is mostly to tackle bugs like https://github.com/netty/netty/issues/832 (JDK issue