pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-436566067
@yanghua if the tests are not stable for 2.0 connector, they should be fixed.
@shaoxuan-wang what test fai
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-435900933
I meant `flink-java` because you are explicitly using `ParameterTool` class
from that package. Aren't you? You a
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-434608568
Please try adding `|| echo ""` after `awk '{print $1}'`, like in this
example:
```
set -x
set -e
set
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-434354247
@yanghua it's not OK if we do not add `set -e`. The error would be still
there, but it would just be silently ig
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-434311640
How do they fail? I would say they should be fixed and if errors are
expected, they should be handled.
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-434241140
I would guess "group" from here:
```
kafka-common.sh: $KAFKA_DIR/bin/kafka-consumer-groups.sh --describe -
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-433900147
@yanghua but it need to be fixed somehow, otherwise with `set -e` the script
will be failing (from time to time?
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-433873778
@yanghua I've created a jira ticket to fix `set -e` in other scripts
https://issues.apache.org/jira/browse/FLINK
pnowojski commented on issue #6924: [FLINK-10600] Provide End-to-end test cases
for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#issuecomment-433449682
@yanghua do you mean this end-to-end test is failing because of
https://issues.apache.org/jira/browse/FLINK-1010
