[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-30 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-434224603 The base module does not currently remove the dependency on kafka. We seem to have discussed it when implementing the kafka 1.0 version of

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-29 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-434147725 @pnowojski Not only the modern kafka connector, but also other connectors. Each version of the flink-connector relies on the base module,

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-26 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-433583162 @pnowojski Yes, I have created [FLINK-10701](https://issues.apache.org/jira/browse/FLINK-10701) to track this problem. -

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-26 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-433387046 hi @pnowojski see [here](https://github.com/apache/flink/pull/6890#issuecomment-431917344). -

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-18 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-431216581 @alexeyt820 I have moved these two issues into FLINK-10598 as a sub issue. ---

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-18 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430942015 @aljoscha I have create an umbrella issue ([FLINK-10598](https://issues.apache.org/jira/browse/FLINK-10598)) to track the issues about th

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-17 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430534660 @alexeyt820 @aljoscha Do you agree I create an umbrella issue for the modern kafka connector? ---

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-16 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430458901 @zentol I did increase the timeout for some tests, because in the new kafka client, the default timeout for some APIs (the API for getting

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-16 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430307620 @aljoscha Yes, I am happy to follow up on the documentation and strengthen the testing of it. Considering that 1.7 is released soon, I sti

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-16 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430275036 Maybe we can create an umbrella issue on JIRA to track the unfinished work around this PR. After it will be merged, I am also happy to con

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-16 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-430130606 Is there anything else I need to do about this PR? This is an automated m

[GitHub] yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka

2018-10-15 Thread GitBox
yanghua commented on issue #6703: [FLINK-9697] Provide connector for modern Kafka URL: https://github.com/apache/flink/pull/6703#issuecomment-429991327 cc @aljoscha This is an automated message from the Apache Git Service. To