Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-02-05 Thread via GitHub
twalthr closed pull request #24073: [DRAFT] FLIP-376 DISTRIBUTED BY URL: https://github.com/apache/flink/pull/24073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-02-05 Thread via GitHub
twalthr commented on PR #24073: URL: https://github.com/apache/flink/pull/24073#issuecomment-1927148744 Replaced by #24155. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
jnh5y commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452485481 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTemporar

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
jnh5y commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452483934 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTemporar

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
jnh5y commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452482693 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTemporar

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
jnh5y commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452481931 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java: ## @@ -144,4 +167,76 @@ default Map toProperties() { default Option

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
dawidwys commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452353552 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java: ## @@ -144,4 +167,76 @@ default Map toProperties() { default Opt

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
dawidwys commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452329548 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTempo

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
dawidwys commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452328881 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTempo

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-15 Thread via GitHub
dawidwys commented on code in PR #24073: URL: https://github.com/apache/flink/pull/24073#discussion_r1452326887 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1348,6 +1352,29 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean isTempo

Re: [PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-11 Thread via GitHub
flinkbot commented on PR #24073: URL: https://github.com/apache/flink/pull/24073#issuecomment-1888126956 ## CI report: * 03494cb182c4f0e3fa4e407dc1f3b06dc9db40b9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [DRAFT] FLIP-376 DISTRIBUTED BY [flink]

2024-01-11 Thread via GitHub
jnh5y opened a new pull request, #24073: URL: https://github.com/apache/flink/pull/24073 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on e