pnowojski opened a new pull request, #24895:
URL: https://github.com/apache/flink/pull/24895
## What is the purpose of the change
Currently many operators when processing watermarks, are firing multiple
timers each producing potentially multiple output records. If this happens
under
flinkbot commented on PR #24895:
URL: https://github.com/apache/flink/pull/24895#issuecomment-2150070746
## CI report:
* f49f6d9b8bec489df19964cf66af93c320cb872a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1630562624
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MailboxWatermarkProcessor.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Softwa
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631413812
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactoryUtil.java:
##
@@ -86,7 +86,11 @@ Tuple2> createOperator(
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631415985
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java:
##
@@ -40,6 +40,15 @@
*/
@Internal
public interfac
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631419185
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,36 @@ void onProcessingTime(long time
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631423299
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MailboxWatermarkProcessor.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Soft
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631426794
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxExecutorImpl.java:
##
@@ -103,4 +103,9 @@ public boolean tryYield() {
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631428461
##
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskMailboxTestHarness.java:
##
@@ -136,6 +136,17 @@ public boolean processSingle
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1632622930
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java:
##
@@ -40,6 +40,15 @@
*/
@Internal
public interface
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1632623556
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,36 @@ void onProcessingTime(long time)
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1632799682
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,36 @@ void onProcessingTime(long time
Zakelly commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1634298332
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,37 @@ void onProcessingTime(long time)
pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1634312543
##
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceImpl.java:
##
@@ -307,18 +307,37 @@ void onProcessingTime(long time
1996fanrui commented on PR #24895:
URL: https://github.com/apache/flink/pull/24895#issuecomment-2161973417
It seems one test related to timer fails, it maybe caused by this PR.
`StreamTaskCancellationTest.testCancelTaskShouldPreventAdditionalEventTimeTimersFromBeingFired:272->testCanc
pnowojski commented on PR #24895:
URL: https://github.com/apache/flink/pull/24895#issuecomment-2162389538
Yes, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
pnowojski merged PR #24895:
URL: https://github.com/apache/flink/pull/24895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
17 matches
Mail list logo
