affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2172535386
> Yeah, the test failure is unrelated
([FLINK-35042](https://issues.apache.org/jira/browse/FLINK-35042)).
Unfortunately, we missed to get it in before the feature freeze. Let's merge it
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2171654110
Yeah, the test failure is unrelated (FLINK-35042). Unfortunately, we missed
to get it in before the feature freeze. Let's merge it after the release branch
for 1.20 is created.
--
This
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2165511898
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1637750136
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1632637479
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1627696194
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1627611020
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1627390009
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1627196144
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1626077906
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624446134
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624443303
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624191535
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1624191535
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1622617735
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2139041576
@XComp done!
Don't worry in any case, I loved the review process. This is my first
contribution and this is part of learning for next ones 欄
--
This is an automated message from
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2138886095
One final thing: I wasn't able to do it myself somehow. Can you change the
commit message prefix from `[refactor]` to `[FLINK-20398]`? "refactor" isn't a
prefix the Flink community usually
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2138868656
I'm not gonna wait for another CI round. Looks like the CI bot didn't pick
up the rerun command. Anyway, I verified that the test ran (see
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2137605027
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2137601891
CI test failure is unrelated: FLINK-34513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1618480332
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1618451567
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1618443253
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1616241149
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2127135299
@XComp Hello!
Final touches done and your comments are addressed
I added the capability for `FromElementsSource` to accept a
`ElementsSupplier` at init phase.
The problem
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1609692387
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1609692387
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1609688204
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/GeneratedRow.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1600075906
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/GeneratedRow.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
morazow commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1563396268
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java:
##
@@ -114,104 +129,24 @@ public void
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1562170708
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1562169902
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java:
##
@@ -114,104 +129,24 @@ public void
morazow commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1561946899
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2049852124
@XComp Glad for your vacation!
Finally I also addressed the deprecation warnings and went through the
implementation of a custom connector through `DynamicTableSource`.
It turned
XComp commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2033738415
fyi: I will be off for the rest of April and, therefore, wouldn't be able to
finalize this PR. You might want to reach out to other committers or expect a
delay in my responses.
--
This
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1543172250
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java:
##
@@ -34,66 +35,105 @@
import
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1541160078
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java:
##
@@ -34,66 +35,105 @@
import
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2018234458
@XComp everything should be ok now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2007495060
@XComp
Required quite of an effort honestly, but here we are with the JUnit5
version of what I had before
This also allowed not to start a separate jar, but to directly
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1530613302
##
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkDistribution.java:
##
@@ -234,10 +234,7 @@ public JobID
affo commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1530612428
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/resources/log4j2-test.properties:
##
@@ -0,0 +1,31 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2003878871
@XComp thank you for your review, gonna address the feedback today (as I had
a week off)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
XComp commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1525110715
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/BatchSQLTest.java:
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-1988639429
@wuchong @XComp
Hi guys, here is the PR for
https://issues.apache.org/jira/browse/FLINK-20398.
I decided to go for `LocalStandaloneFlinkResourceFactory` as it is already
used
flinkbot commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-1985868527
## CI report:
* 35acd12f6acdd8c132f3dbc365c5c24549b7bc18 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
affo opened a new pull request, #24471:
URL: https://github.com/apache/flink/pull/24471
## What is the purpose of the change
Migrate `test_batch_sql.sh` to end-to-end test frameworks.
## Brief change log
- implement `BatchSQLTest` porting `test_batch_sql.sh`
-
50 matches
Mail list logo
