Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-07-22 Thread via GitHub
rjbaucells commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2243290547 Hello, What is the status of this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-07-11 Thread via GitHub
vahmed-hamdy commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2223412688 @paulh86 Blocked on review from the community, will reach out on dev slack channel for a reviewer -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-07-03 Thread via GitHub
paulh86 commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2205851900 Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-22 Thread via GitHub
morazow commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1609538026 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/sink/RabbitMQSinkWriter.java: ## @@ -0,0 +1,258 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-22 Thread via GitHub
morazow commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1609531137 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/sink/RabbitMQSinkWriter.java: ## @@ -0,0 +1,260 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-17 Thread via GitHub
vahmed-hamdy commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1604736511 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/RabbitMQConnectionConfig.java: ## @@ -0,0 +1,465 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-17 Thread via GitHub
vahmed-hamdy commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1604735515 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/sink/RabbitMQSinkWriter.java: ## @@ -0,0 +1,260 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-17 Thread via GitHub
vahmed-hamdy commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1604725820 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/RabbitMQConnectionSetupException.java: ## @@ -0,0 +1,13 @@

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-17 Thread via GitHub
vahmed-hamdy commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1604717135 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/RabbitMQConnectionConfig.java: ## @@ -0,0 +1,465 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-15 Thread via GitHub
morazow commented on code in PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1601778225 ## flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/RabbitMQConnectionConfig.java: ## @@ -0,0 +1,465 @@ +package

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-03 Thread via GitHub
vahmed-hamdy commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2092561482 @MartijnVisser @zentol could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-02 Thread via GitHub
vahmed-hamdy opened a new pull request, #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29 ## Purpose of the change Add SinkV2 implemetation for RabbitMQ. ## Verifying this change Please make sure both new and modified tests in this PR follows

Re: [PR] [FLINK-21373] Add RabbitMQ SinkV2 Implementation, Port Flink version to Flink 1.19 [flink-connector-rabbitmq]

2024-05-02 Thread via GitHub
boring-cyborg[bot] commented on PR #29: URL: https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2090628185 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This