dawidwys merged PR #24253:
URL: https://github.com/apache/flink/pull/24253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on PR #24253:
URL: https://github.com/apache/flink/pull/24253#issuecomment-1934213444
yes, also played locally , seems working, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1482693914
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalJoinTestPrograms.java:
##
@@ -84,6 +130,36 @@ public
dawidwys commented on PR #24253:
URL: https://github.com/apache/flink/pull/24253#issuecomment-1933701764
@snuyanzin There is a test for using an entry from a map:
```
INSERT INTO MySink
SELECT amount * r.rate
FROM OrdersNestedId AS o
JOIN RatesHistory FOR SYSTEM_TIME AS OF
snuyanzin commented on PR #24253:
URL: https://github.com/apache/flink/pull/24253#issuecomment-1933613412
Out of curiocity: I didn't find tests for nested arrays/maps/row... Are they
out of scope?
I mean e.g. this
```sql
CREATE TABLE A (
a MAP>,
ts
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481739305
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -323,15
jnh5y commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481698481
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -323,15
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481687197
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -323,15
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481689031
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalJoinTestPrograms.java:
##
@@ -84,6 +130,36 @@ public
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481688174
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -237,57
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481688174
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -237,57
dawidwys commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481687197
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -323,15
jnh5y commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481681792
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -237,57
jnh5y commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481679233
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableRule.scala:
##
@@ -323,15
jnh5y commented on code in PR #24253:
URL: https://github.com/apache/flink/pull/24253#discussion_r1481662098
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalJoinTestPrograms.java:
##
@@ -84,6 +130,36 @@ public class
flinkbot commented on PR #24253:
URL: https://github.com/apache/flink/pull/24253#issuecomment-1924021657
## CI report:
* e06aee059e610ce72fb153eff7c8f466cde82bfa UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dawidwys opened a new pull request, #24253:
URL: https://github.com/apache/flink/pull/24253
## What is the purpose of the change
This makes it possible to use more complex keys for temporal join. It tries
pushing down join predicates before extracting join keys which makes more cases
17 matches
Mail list logo
